-
Notifications
You must be signed in to change notification settings - Fork 39
replace jre based yui compressor with .net msbuild version #649
Conversation
@ohine did you have a plan to address the build error:
I took a look at it and wasn't able to find a way to suppress the error or add some placeholder content to the CSS file to quiet the warning. Is Webpack already minifying, and the YUI step is unnecessary? Or do we just need to not target this one file? |
@bdukes Yes, I was planning on circling back and getting this fixed, we definitely don't want to run YUI on the webapp folders, but I think we do want to run it on these files as yarn/webpack/etc isn't setup to process those folders. Do we even need the roles.css file if it's empty? Can we just delete it? |
After removing files related to
So I think the MSBuild task still needs to be adjusted :-/ |
@ohine I pushed a couple of commits to address those errors 🤞 |
@bdukes Thanks!! I was in the middle of wrapping up another issue before switching back to this! 🤞 for sure! |
Looks like our checks are green, just need some approvals |
Upon review, I pushed one more change to comment out the JS minification pieces to clarify that they're unused. |
@ohine Want this merged now? |
Summary
Closes #377